Compose POC #51
Open
Compose POC #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! Any ideas how it could evolve? |
|
Hi @e13mort, must've missed the notification. I haven't really looked at this much since I've made the PR. I'm not sure this could evolve very far tbh. libui is too rigid for Compose. Having to recreate a parent every time some component is added/removed from the composition feels kinda ridiculous. |
|
Please @Dominaezzz what do you think of projects like Calf and Compose-look-and-feel? Are they ways to evolve what this PR aims to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts #40 .
I've only tried this on Linux. I'm curious to see if this works on other OSes, as I can't currently test this.
Just run any of these:
./gradlew :libui-compose:runReleaseExecutableLinux./gradlew :libui-compose:runReleaseExecutableMacosx./gradlew :libui-compose:runReleaseExecutableWindowsI managed to support some widgets and groups however there's quite a few bits missing.
I'm not sure how to pass group widget attributes from the child to the parent's applier. Stuff like
isStretchyandtabLabel.A lot of the group widgets don't map nicely to compose but there are workarounds at least.